sys/windows: update docs about secure way to load system DLLs #13
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinderek
force-pushed
the
master
branch
6 times, most recently
from
7a1679d to
121e5bb
Compare
|
🔍 This pull request has been sent to HackerOne's PullRequest review team because our automation detected one or more changes with potential security impact or requires further evaluation. Experts are now being assigned to this review based on relevant expertise and will validate or dismiss any security findings accordingly and post their feedback as comments within this pull request. ⏱️ Latest scan covered changes up to commit 384b795 (latest) Check the status or cancel this secure code review here. |
austinderek
force-pushed
the
master
branch
23 times, most recently
from
121e5bb to
7a1679d
Compare
austinderek
force-pushed
the
master
branch
30 times, most recently
from
6a08e80 to
37c78b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, the documentation of the
syscall.LazyDLLstates to usewindows.LazyDLLfor secure loading of system DLLs. However, the use of thewindows.LazyDLLstructure is only secure (not vulnerable to DLL preloading/injection attacks) if the user creates the object through thewindows.NewLazySystemDLLfunction or if they usewindows.NewLazyDLLwith an absolute path.Given all this, I think it is better to point to
windows.NewLazySystemDLLfunction instead of thewindows.LazyDLLstructure in thesyscall.LazyDLLdocumentation.🔄 This is a mirror of upstream PR #74284